Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: remoting/client/plugin/pepper_video_renderer_3d.cc

Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Note frequency at which UMA stats are being updated/logged. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_video_renderer_3d.cc
diff --git a/remoting/client/plugin/pepper_video_renderer_3d.cc b/remoting/client/plugin/pepper_video_renderer_3d.cc
index 711c2104b702cf083f78a4b4b337286fb20eb91e..9f0ece6e345d112e75e495347446171b1015519d 100644
--- a/remoting/client/plugin/pepper_video_renderer_3d.cc
+++ b/remoting/client/plugin/pepper_video_renderer_3d.cc
@@ -189,12 +189,15 @@ void PepperVideoRenderer3D::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
const base::Closure& done) {
base::ScopedClosureRunner done_runner(done);
+ stats_.video_packet_rate()->Record(1);
Wez 2015/07/14 20:24:17 nit: Leave a blank line between this code and the
anandc 2015/07/15 03:59:55 Done.
// Don't need to do anything if the packet is empty. Host sends empty video
// packets when the screen is not changing.
if (!packet->data().size())
return;
// Update statistics.
+ // TODO(anandc): The following tasks are duplicated in
+ // software_video_renderer.cc. Move to ChromotingStats: http://crbug/508602
Wez 2015/07/14 20:24:17 nit: Suggest reducing to "TODO(...): Move this wor
anandc 2015/07/15 03:59:55 Done.
stats_.video_frame_rate()->Record(1);
stats_.video_bandwidth()->Record(packet->data().size());
if (packet->has_capture_time_ms())

Powered by Google App Engine
This is Rietveld 408576698