remoting/client/plugin/chromoting_instance.h - Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/chromoting_instance.h

Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Declare time-window constants as static. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/client/chromoting_stats.h ('K') | « remoting/client/chromoting_stats.cc ('k') | remoting/client/plugin/chromoting_instance.cc » ('j') | remoting/client/plugin/chromoting_instance.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/client/plugin/chromoting_instance.h

diff --git a/remoting/client/plugin/chromoting_instance.h b/remoting/client/plugin/chromoting_instance.h

index 7f600bb1d9aecb35dc2c87163135479a92fb3039..15586e95450c98d50dc7a90b2841b97892c5905c 100644

--- a/remoting/client/plugin/chromoting_instance.h

+++ b/remoting/client/plugin/chromoting_instance.h

@@ -219,7 +219,9 @@ class ChromotingInstance : public ClientUserInterface,

// Callback for DelegatingSignalStrategy.

void SendOutgoingIq(const std::string& iq);

- void SendPerfStats();

+ void SendDisplayPerfStats();

+ void SendUMAPerfStats();

Wez 2015/07/08 23:42:29 nit: SendUmaPerfStats() as per style-guide naming

anandc 2015/07/09 19:17:10 Reverted to a single function now.

void ProcessLogToUI(const std::string& message);