remoting/client/server_log_entry_client.cc - Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/server_log_entry_client.cc

Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set time-window for display stats rate-counters to 3. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/client/plugin/chromoting_instance.cc ('K') | « remoting/client/plugin/pepper_video_renderer_3d.cc ('k') | remoting/client/software_video_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/client/server_log_entry_client.cc

diff --git a/remoting/client/server_log_entry_client.cc b/remoting/client/server_log_entry_client.cc

index 2f78150205d19efd08c5374c4d63bbb7056346bc..0cb35623b608326776cf34ead4c6e6e7469ee126 100644

--- a/remoting/client/server_log_entry_client.cc

+++ b/remoting/client/server_log_entry_client.cc

@@ -115,7 +115,8 @@ scoped_ptr<ServerLogEntry> MakeLogEntryForStatistics(

entry->AddEventNameField(kValueEventNameStatistics);

entry->Set("video-bandwidth",

- StringPrintf("%.2f", statistics->video_bandwidth()->Rate()));

+ StringPrintf("%.2f",

+ statistics->video_bandwidth_display()->Rate()));

entry->Set("capture-latency",

StringPrintf("%.2f", statistics->video_capture_ms()->Average()));

entry->Set("encode-latency",

@@ -123,7 +124,8 @@ scoped_ptr<ServerLogEntry> MakeLogEntryForStatistics(

entry->Set("decode-latency",

StringPrintf("%.2f", statistics->video_decode_ms()->Average()));

entry->Set("render-latency",

- StringPrintf("%.2f", statistics->video_frame_rate()->Rate()));

+ StringPrintf("%.2f",

+ statistics->video_frame_rate_display()->Rate()));

entry->Set("roundtrip-latency",

StringPrintf("%.2f", statistics->round_trip_ms()->Average()));