Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: remoting/client/software_video_renderer.cc

Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify metric names. Better document UMA min-max and boundary settings. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/software_video_renderer.cc
diff --git a/remoting/client/software_video_renderer.cc b/remoting/client/software_video_renderer.cc
index 51782e05f476f4942a30408a7e52d0214cc0a80f..befa7eb71f8144811d7b68463ce55b07e4011683 100644
--- a/remoting/client/software_video_renderer.cc
+++ b/remoting/client/software_video_renderer.cc
@@ -352,16 +352,19 @@ void SoftwareVideoRenderer::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
// If the video packet is empty then drop it. Empty packets are used to
// maintain activity on the network.
+ stats_.video_packets_per_s_UMA()->Record(1);
anandc 2015/06/30 20:17:39 There is some duplication here with https://code.g
if (!packet->has_data() || packet->data().size() == 0) {
done.Run();
return;
}
- // Add one frame to the counter.
- stats_.video_frame_rate()->Record(1);
+ // Add one frame to the video frame rate counters.
+ stats_.video_fps_webapp()->Record(1);
+ stats_.video_fps_UMA()->Record(1);
// Record other statistics received from host.
- stats_.video_bandwidth()->Record(packet->data().size());
+ stats_.video_Bps_webapp()->Record(packet->data().size());
+ stats_.video_Bps_UMA()->Record(packet->data().size());
if (packet->has_capture_time_ms())
stats_.video_capture_ms()->Record(packet->capture_time_ms());
if (packet->has_encode_time_ms())

Powered by Google App Engine
This is Rietveld 408576698