Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: remoting/client/plugin/pepper_video_renderer_3d.cc

Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary RunningAverage stats. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_video_renderer_3d.cc
diff --git a/remoting/client/plugin/pepper_video_renderer_3d.cc b/remoting/client/plugin/pepper_video_renderer_3d.cc
index 711c2104b702cf083f78a4b4b337286fb20eb91e..3bf5619dbbeb39faca331dfec65dae6390c70b79 100644
--- a/remoting/client/plugin/pepper_video_renderer_3d.cc
+++ b/remoting/client/plugin/pepper_video_renderer_3d.cc
@@ -189,14 +189,18 @@ void PepperVideoRenderer3D::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
const base::Closure& done) {
base::ScopedClosureRunner done_runner(done);
+ stats_.video_fps_with_empty_frames()->Record(1);
// Don't need to do anything if the packet is empty. Host sends empty video
// packets when the screen is not changing.
- if (!packet->data().size())
+ if (!packet->data().size()) {
return;
+ }
// Update statistics.
stats_.video_frame_rate()->Record(1);
+ stats_.video_fps()->Record(1);
stats_.video_bandwidth()->Record(packet->data().size());
+ stats_.video_bytes_per_s()->Record(packet->data().size());
Wez 2015/06/29 14:56:13 This ends up being pretty ugly. Could we instead
anandc 2015/06/30 20:17:39 Agreed. If we use only the per-second sampling, t
if (packet->has_capture_time_ms())
stats_.video_capture_ms()->Record(packet->capture_time_ms());
if (packet->has_encode_time_ms())

Powered by Google App Engine
This is Rietveld 408576698