Report video and network stats averaged over 1s, and create corresponding UMA metrics.

remoting/client/chromoting_stats.cc

Index: remoting/client/chromoting_stats.cc
diff --git a/remoting/client/chromoting_stats.cc b/remoting/client/chromoting_stats.cc
index 71b7199ff5adca1f9222636bb5cc5fe79efedea8..e029cbebc1e30fb4518261f60222c6db8fc02663 100644
--- a/remoting/client/chromoting_stats.cc
+++ b/remoting/client/chromoting_stats.cc
@@ -9,6 +9,9 @@ namespace {
 // The default window of bandwidth and frame rate in seconds.
 const int kTimeWindow = 3;

[Wez, 2015/06/29 14:56:13]

nit: Rename this to clarify why it differs from the other windows below.

[anandc, 2015/06/30 20:17:38]

Done.

 
+// Window for more fine-grained stats
+const int kOneSecWindow = 1;

[Wez, 2015/06/29 14:56:13]

Don't name this after the actual amount it represents - then you may as well
just use the literal 1 in the code. If you instead name it after the concept it
represents, e.g. kFineGrainedStatsWindowSecs then you no longer need to ranem it
if the value changes, and you've expressed its meaning/purpose.

[anandc, 2015/06/30 20:17:38]

Done. Thanks. :-)

+
 // We take the last 10 latency numbers and report the average.
 const int kLatencyWindow = 10;

[Wez, 2015/06/29 14:56:13]

nit: Rename this to include the units in the name?

[anandc, 2015/06/30 20:17:38]

Done.

 
@@ -19,6 +22,9 @@ namespace remoting {
 ChromotingStats::ChromotingStats()
     : video_bandwidth_(base::TimeDelta::FromSeconds(kTimeWindow)),
       video_frame_rate_(base::TimeDelta::FromSeconds(kTimeWindow)),
+      video_fps_(base::TimeDelta::FromSeconds(kOneSecWindow)),
+      video_bytes_per_s_(base::TimeDelta::FromSeconds(kOneSecWindow)),
+      video_fps_with_empty_frames_(base::TimeDelta::FromSeconds(kOneSecWindow)),
       video_capture_ms_(kLatencyWindow),
       video_encode_ms_(kLatencyWindow),
       video_decode_ms_(kLatencyWindow),