Report video and network stats averaged over 1s, and create corresponding UMA metrics.

remoting/client/software_video_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/software_video_renderer.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 332 matching lines @@
 }
 
 protocol::VideoStub* SoftwareVideoRenderer::GetVideoStub() {
   return this;
 }
 
 void SoftwareVideoRenderer::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
                                                 const base::Closure& done) {
   DCHECK(CalledOnValidThread());
 
+  stats_.video_packet_rate()->Record(1);

[Wez, 2015/07/14 20:24:17]

See comments in the Pepper 3D renderer re layout & comments.

[anandc, 2015/07/15 03:59:55]

Done.

   // If the video packet is empty then drop it. Empty packets are used to
   // maintain activity on the network.
   if (!packet->has_data() || packet->data().size() == 0) {
     done.Run();

[Wez, 2015/07/14 20:24:17]

nit: We should be doing done.Run() here and below with a ScopedTaskRunner...
something for the refactoring CL.

[anandc, 2015/07/15 03:59:55]

Added note to tracking bug.

     return;
   }
 
-  // Add one frame to the counter.
-  stats_.video_frame_rate()->Record(1);
+  // Add one frame to the video frame rate counters.

[Wez, 2015/07/14 20:24:17]

You're only updating a single counter here, though?

[anandc, 2015/07/15 03:59:55]

Done. Holdover from a previous patch-set. Thanks for catching.

+  stats_.video_bandwidth()->Record(1);

[Wez, 2015/07/14 20:24:17]

Looks like you've mistakenly swapped bandwidth & frame rate?

[anandc, 2015/07/15 03:59:55]

Aargh, and didn't catch it even with a diff. Thanks a lot. Done.

 
   // Record other statistics received from host.
-  stats_.video_bandwidth()->Record(packet->data().size());
+  stats_.video_frame_rate()->Record(packet->data().size());
   if (packet->has_capture_time_ms())
     stats_.video_capture_ms()->Record(packet->capture_time_ms());
   if (packet->has_encode_time_ms())
     stats_.video_encode_ms()->Record(packet->encode_time_ms());
   if (packet->has_latest_event_timestamp() &&
       packet->latest_event_timestamp() > latest_event_timestamp_) {
     latest_event_timestamp_ = packet->latest_event_timestamp();
     base::TimeDelta round_trip_latency =
         base::Time::Now() -
         base::Time::FromInternalValue(packet->latest_event_timestamp());
@@ skipping 46 matching lines @@
   DCHECK(CalledOnValidThread());
 
   // Record the latency between the packet being received and presented.
   stats_.video_decode_ms()->Record(
       (base::Time::Now() - decode_start).InMilliseconds());
 
   done.Run();
 }
 
 }  // namespace remoting