Report video and network stats averaged over 1s, and create corresponding UMA metrics.

remoting/client/chromoting_stats.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ChromotingStats defines a bundle of performance counters and statistics
 // for chromoting.
 
 #ifndef REMOTING_CLIENT_CHROMOTING_STATS_H_
 #define REMOTING_CLIENT_CHROMOTING_STATS_H_
 
 #include "remoting/base/rate_counter.h"
 #include "remoting/base/running_average.h"
 
 namespace remoting {
 
 class ChromotingStats {
  public:
   ChromotingStats();
   virtual ~ChromotingStats();
 
-  RateCounter* video_bandwidth() { return &video_bandwidth_; }
-  RateCounter* video_frame_rate() { return &video_frame_rate_; }
+  RateCounter* video_Bps_webapp() { return &video_Bps_webapp_; }

[Sergey Ulanov, 2015/07/06 21:23:12]

style guide doesn't allow mixed case names like these. Also abbreviations like
"bps" and "fps" are discouraged. Another problem is that _webapp suffix doesn't
make sense for android and iOS builds.
I suggest the followingnames:
video_bandwidth_display()
video_frame_rate_display()
video_bandwidth_uma()
video_frame_rate_uma()

[anandc, 2015/07/07 01:11:43]

Done.

+  RateCounter* video_fps_webapp() { return &video_fps_webapp_; }
+  RateCounter* video_Bps_UMA() { return &video_Bps_UMA_; }
+  RateCounter* video_fps_UMA()  { return &video_fps_UMA_; }
+  RateCounter* video_packets_per_s_UMA() {

[Sergey Ulanov, 2015/07/06 21:23:12]

Maybe call it video_packet_rate_uma()?

[anandc, 2015/07/07 01:11:43]

Done.

+    return &video_packets_per_s_UMA_;
+  }
   RunningAverage* video_capture_ms() { return &video_capture_ms_; }
   RunningAverage* video_encode_ms() { return &video_encode_ms_; }
   RunningAverage* video_decode_ms() { return &video_decode_ms_; }
   RunningAverage* video_paint_ms() { return &video_paint_ms_; }
   RunningAverage* round_trip_ms() { return &round_trip_ms_; }
 
  private:
-  RateCounter video_bandwidth_;
-  RateCounter video_frame_rate_;
+  // The following 2 metrics are used in the stats captured every 60s for

[Sergey Ulanov, 2015/07/06 21:23:12]

IMO it would be better to move put these comments next to the public accessors
above

[anandc, 2015/07/07 01:11:43]

Done.

+  // display within the web-app.

[Sergey Ulanov, 2015/07/06 21:23:12]

"web-app" doesn't make sense in context of android app.

[anandc, 2015/07/07 01:11:43]

Done.

+  // Bytes/sec for non-empty packets, measured over a 3s time-window.
+  RateCounter video_Bps_webapp_;
+  // frames/sec for non-empty video-packets, measured over a 3s time-window.
+  RateCounter video_fps_webapp_;
+  // The next 3 metrics are used to record statistics for upload to UMA.
+  // Bytes/sec for non-empty video-packets, measured over a 1s time-window.
+  RateCounter video_Bps_UMA_;
+  // frames/sec for non-empty video-packets, measured over a 1s time-window.
+  RateCounter video_fps_UMA_;
+  // packets/sec, including empty video-packets, measured over a 1s time-window.
+  RateCounter video_packets_per_s_UMA_;
+  // The following metrics report averages calculated when updating stats.
+  // For UMA, the updates occur every second. For stats shown to users, they are
+  // updated every 60s.
+  // Time to capture video, measured in ms.
   RunningAverage video_capture_ms_;
+  // Time to encode a captured video-packet, measured in ms.

[Sergey Ulanov, 2015/07/06 21:23:12]

"measured in ms" is redundant because there is ms_ suffix.

[anandc, 2015/07/07 01:11:43]

Done.

   RunningAverage video_encode_ms_;
+  // Time to decode a video-packet, measured in ms.
   RunningAverage video_decode_ms_;
+  // Time to paint, measured in ms. Only updated if there is a picture to paint,
+  // or on force-repaint.
   RunningAverage video_paint_ms_;
+  // Round-trip latency, measured in ms.
   RunningAverage round_trip_ms_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingStats);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_CHROMOTING_STATS_H_