Report video and network stats averaged over 1s, and create corresponding UMA metrics.

remoting/client/chromoting_stats.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/chromoting_stats.h"
 
 namespace {
 
 // The default window of bandwidth and frame rate in seconds.
-const int kTimeWindow = 3;
+// This is used for obtaining rates over the specified window for reporting to
+// users in the web-app.
+const int kWebAppStatsTimeWindow = 3;

[Sergey Ulanov, 2015/07/06 21:23:12]

I suggest calling it kDisplayStatsTimeWindowSeconds to avoid dependency on
"webapp" and to make it clear which units we use here.

[anandc, 2015/07/07 01:11:43]

Done.

+
+// Window for more fine-grained stats
+const int kFineGrainedStatsWindow = 1;

[Sergey Ulanov, 2015/07/06 21:23:12]

kUmaStatsWindowSeconds

[Sergey Ulanov, 2015/07/06 21:23:12]

This value is essentially duplicated in as kPerfStatsIntervalMs in
remoting/client/plugin/chromoting_instance.cc. I suggest making it a public
const in ChromotingStats and using in chromoting_instance.cc. to make sure that
UMA stats are reported at the correct rate. And then it might be better to have
2 separate timers: 1 to report UMA stats and another one to update UI.

[anandc, 2015/07/07 01:11:42]

Done.

[anandc, 2015/07/07 01:11:43]

Done.

 
 // We take the last 10 latency numbers and report the average.
-const int kLatencyWindow = 10;
+const int kLatencyWindowInSeconds = 10;
 
 }  // namespace
 
 namespace remoting {
 
 ChromotingStats::ChromotingStats()
-    : video_bandwidth_(base::TimeDelta::FromSeconds(kTimeWindow)),
-      video_frame_rate_(base::TimeDelta::FromSeconds(kTimeWindow)),
-      video_capture_ms_(kLatencyWindow),
-      video_encode_ms_(kLatencyWindow),
-      video_decode_ms_(kLatencyWindow),
-      video_paint_ms_(kLatencyWindow),
-      round_trip_ms_(kLatencyWindow) {
+    : video_Bps_webapp_(base::TimeDelta::FromSeconds(kWebAppStatsTimeWindow)),
+      video_fps_webapp_(base::TimeDelta::FromSeconds(kWebAppStatsTimeWindow)),
+      video_Bps_UMA_(base::TimeDelta::FromSeconds(kFineGrainedStatsWindow)),
+      video_fps_UMA_(base::TimeDelta::FromSeconds(kFineGrainedStatsWindow)),
+      video_packets_per_s_UMA_(
+        base::TimeDelta::FromSeconds(kFineGrainedStatsWindow)),
+      video_capture_ms_(kLatencyWindowInSeconds),
+      video_encode_ms_(kLatencyWindowInSeconds),
+      video_decode_ms_(kLatencyWindowInSeconds),
+      video_paint_ms_(kLatencyWindowInSeconds),
+      round_trip_ms_(kLatencyWindowInSeconds) {
 }
 
 ChromotingStats::~ChromotingStats() {
 }
 
 }  // namespace remoting