Report video and network stats averaged over 1s, and create corresponding UMA metrics.

remoting/client/chromoting_stats.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ChromotingStats defines a bundle of performance counters and statistics
 // for chromoting.
 
 #ifndef REMOTING_CLIENT_CHROMOTING_STATS_H_
 #define REMOTING_CLIENT_CHROMOTING_STATS_H_
 
 #include "remoting/base/rate_counter.h"
 #include "remoting/base/running_average.h"
 
 namespace remoting {
 
 class ChromotingStats {
  public:
   ChromotingStats();
   virtual ~ChromotingStats();
 
   RateCounter* video_bandwidth() { return &video_bandwidth_; }

[Wez, 2015/06/29 14:56:13]

While you're here, can we add aunits suffix to this member, please?

[anandc, 2015/06/30 20:17:39]

I've used Bps, to indicate Bytes/sec.

   RateCounter* video_frame_rate() { return &video_frame_rate_; }
+  RateCounter* video_fps()  { return &video_fps_; }

[Wez, 2015/06/29 14:56:13]

What is the difference between this and video_frame_rate(), above...?

[anandc, 2015/06/30 20:17:38]

Video frame-rate has a time-window of 3s. This one has a time-window of 1s.

I've added a suffix to indicate the way these metrics are used.

+  RateCounter* video_bytes_per_s() { return &video_bytes_per_s_; }

[Wez, 2015/06/29 14:56:13]

Similarly, consider clarifying how this differs from "bandwidth", above?

[anandc, 2015/06/30 20:17:38]

Done.

+  RateCounter* video_fps_with_empty_frames() {

[Wez, 2015/06/29 14:56:13]

There is a 1:1 correspondence between video frames and video packets (aka
VideoPacket in our protocol) - it may be clearer to use video_packets_per_s()
here.

You may wish to add comments to each of these fields to explain their
purpose/limitations, etc (e.g. the fact that video_fps() will be zero if there
are no actual on-screen changes to deliver.

[anandc, 2015/06/30 20:17:38]

Done.

+    return &video_fps_with_empty_frames_;
+  }
   RunningAverage* video_capture_ms() { return &video_capture_ms_; }
   RunningAverage* video_encode_ms() { return &video_encode_ms_; }
   RunningAverage* video_decode_ms() { return &video_decode_ms_; }
   RunningAverage* video_paint_ms() { return &video_paint_ms_; }
   RunningAverage* round_trip_ms() { return &round_trip_ms_; }
 
  private:
   RateCounter video_bandwidth_;
   RateCounter video_frame_rate_;
+  RateCounter video_fps_;
+  RateCounter video_bytes_per_s_;
+  RateCounter video_fps_with_empty_frames_;
   RunningAverage video_capture_ms_;
   RunningAverage video_encode_ms_;
   RunningAverage video_decode_ms_;
   RunningAverage video_paint_ms_;
   RunningAverage round_trip_ms_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingStats);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_CHROMOTING_STATS_H_