Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 1181743003: Rebuild GraphicsLayer tree when a LayoutPart's CDPLM configuration changes (Closed)

Created:
4 years, 10 months ago by ajuma
Modified:
4 years, 10 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebuild GraphicsLayer tree when a LayoutPart's CDPLM configuration changes When a CompositedDeprecatedPaintLayerMapping's internal configuration changes, the GraphicsLayer tree is rebuilt so that the CDPLM's GraphicsLayers are reconnected to ancestors and descendants. However, for CDPLMs owned by LayoutParts, the decision to rebuild ignores whether the CDPLMs internal configuration has changed. This means that after an internal configuration change (e.g., the removal of an ancestor clipping layer), such a CDPLM's GraphicsLayers can be left disconnected from the rest of the GraphicsLayer tree. This CL rebuilds the GraphicsLayer tree when such a CDPLM's internal configuration changes. BUG=497271 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197471

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
A LayoutTests/compositing/layer-creation/iframe-clip-removed.html View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/compositing/layer-creation/iframe-clip-removed-expected.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ajuma
4 years, 10 months ago (2015-06-19 13:52:48 UTC) #2
Ian Vollick
On 2015/06/19 at 13:52:48, ajuma wrote: > lgtm
4 years, 10 months ago (2015-06-19 13:53:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181743003/40001
4 years, 10 months ago (2015-06-19 13:57:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 14:00:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197471

Powered by Google App Engine
This is Rietveld 408576698