Issue 1181723006: Move closeWindow()/setFullscreen()/setVSynv() from SkWindow to SkOSWindow

Issue 1181723006: Move closeWindow()/setFullscreen()/setVSynv() from SkWindow to SkOSWindow (Closed)

Created:
5 years, 6 months ago by bsalomon

Modified:
5 years, 6 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Move closeWindow()/setFullscreen()/setVSynv() from SkWindow to SkOSWindow Rename setFullscreen to makeFullscreen, drop the param, return a bool. Committed: https://skia.googlesource.com/skia/+/85ab55114f3e2d688d0705e3482fc77ec8a46a64

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -113 lines)			Patch
M	include/views/SkOSWindow_Android.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	include/views/SkOSWindow_Mac.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	include/views/SkOSWindow_Unix.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	include/views/SkOSWindow_Win.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	include/views/SkOSWindow_iOS.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	include/views/SkWindow.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/views/unix/SkOSWindow_Unix.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/views/win/SkOSWindow_win.cpp	View	4 chunks	+70 lines, -97 lines	0 comments	Download
M	tools/VisualBench.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181723006/1

5 years, 6 months ago (2015-06-16 19:42:11 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-16 19:47:30 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85ab55114f3e2d688d0705e3482fc77ec8a46a64