Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4038)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm

Issue 11817051: Elide text in the new Autofill UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fixing compile errors Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
index 00660a1e1e21c42e9e1ba5de1330a3c3377d1c33..8c5c75cf66c965735d8cfa8357dfc49f77a9572a 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.mm
@@ -41,7 +41,6 @@ void AutofillPopupViewBridge::Hide() {
}
void AutofillPopupViewBridge::Show() {
- SetInitialBounds();
UpdateBoundsAndRedrawPopup();
[[controller_->container_view() window] addChildWindow:window_
ordered:NSWindowAbove];
@@ -67,20 +66,6 @@ void AutofillPopupViewBridge::UpdateBoundsAndRedrawPopup() {
[window_ setFrame:frame display:YES];
}
-void AutofillPopupViewBridge::SetInitialBounds() {
- // The bounds rect in Chrome's screen coordinates. The popup should be
- // positioned just below the element which initiated it.
- gfx::Rect bounds(controller_->element_bounds().x(),
- controller_->element_bounds().bottom(),
- controller_->GetPopupRequiredWidth(),
- controller_->GetPopupRequiredHeight());
-
- // TODO(isherman): Position the popup correctly if it can't fit below the text
- // field: http://crbug.com/164603
-
- controller_->SetPopupBounds(bounds);
-}
-
AutofillPopupView* AutofillPopupView::Create(
AutofillPopupController* controller) {
return new AutofillPopupViewBridge(controller);

Powered by Google App Engine
This is Rietveld 408576698