Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2962)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 11817051: Elide text in the new Autofill UI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
index 321d56b43c4ce6b2155ee4cbf4363d474a245c24..b23c4f459af6c6cbbef6faac687a20918fd95697 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
@@ -128,6 +128,15 @@ class AutofillPopupControllerImpl : public AutofillPopupController,
virtual void InvalidateRow(size_t row);
private:
+ // Calculate the width of the row, excluding all the text. This provides
+ // the size of the row that won't be reducable (since all the text can be
Ilya Sherman 2013/01/10 23:34:36 nit: "reducable" -> "reducible"
csharp 2013/01/11 17:51:12 Done.
+ // elided if there isn't enough space).
+ int RowWidthWithoutText(int row);
+
+ // Returns the maximum width (in pixels) that the popup could be before it
+ // would go off the screen edge.
+ virtual int MaxVisiblePopupWidth();
Ilya Sherman 2013/01/10 23:34:36 nit: Why is this virtual? (Add a comment.)
csharp 2013/01/11 17:51:12 Done.
+
AutofillPopupView* view_; // Weak reference.
AutofillPopupDelegate* delegate_; // Weak reference.
gfx::NativeView container_view_; // Weak reference.

Powered by Google App Engine
This is Rietveld 408576698