Elide text in the new Autofill UI

chrome/browser/ui/autofill/autofill_popup_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/string16.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
@@ skipping 110 matching lines @@
   // Returns true if the popup still has non-options entries to show the user.
   bool HasSuggestions();
 
   AutofillPopupView* view() { return view_; }
 
   // |view_| pass throughs (virtual for testing).
   virtual void ShowView();
   virtual void InvalidateRow(size_t row);
 
  private:
+  // Calculate the width of the row, excluding all the text. This provides
+  // the size of the row that won't be reducible (since all the text can be
+  // elided if there isn't enough space).
+  int RowWidthWithoutText(int row);
+
+  // Calculates and sets the width of the popup based on the data to be shown,
+  // the screen size and position of the popup (virtual for testing).
+  virtual int CalculateAndSetPopupWidth();

[Ilya Sherman, 2013/01/11 23:05:35]

IMO the code would be cleaner if this either returned the calculated width or
fully updated the popup_bounds_ directly, rather than partially updating the
popup_bounds_ and also returning the width.  I'd probably recommend the latter
option, and naming this method something like UpdatePopupWidth().

[csharp, 2013/01/14 20:32:33]

Done.

+
   AutofillPopupView* view_;  // Weak reference.
   AutofillPopupDelegate* delegate_;  // Weak reference.
   gfx::NativeView container_view_;  // Weak reference.
 
   // The bounds of the text element that is the focus of the Autofill.
   // These coordinates are in screen space.
   const gfx::Rect element_bounds_;
 
   // The bounds of the Autofill popup.
   gfx::Rect popup_bounds_;
@@ skipping 18 matching lines @@
   bool delete_icon_hovered_;
 
   // True if |HideInternal| has already been called.
   bool is_hiding_;
 
   // True if the delegate should be informed when |this| is destroyed.
   bool inform_delegate_of_destruction_;
 };
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_CONTROLLER_IMPL_H_