Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 11817048: Revert 175648 because it causes http://crbug.com/169126. (Closed)

Created:
7 years, 11 months ago by alexeypa (please no reviews)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert 175648 because it causes http://crbug.com/169126. > Connect to DesktopEnvironment's stubs only when audio/video schedulers are about to be created. > > This CL localizes usage of DesktopEnvironment to a single method that creates audio/video schedulers and hook up the event executor. This prepares further refactoring of DesktopEnvironment that should become a factory for classes interacting with the specific desktop environment. > > Related changes in this CL: > - MouseClampingFilter receives screen size on the proper thread. > - ClientSessionTest.* tests now run asynchronously to support MouseClampingFilter change. > - ClientSession does not expose DesktopEnvironment. > - InputEventTracker can be re-attached to a different InputStub. > > BUG=104544 > > > Review URL: https://chromiumcodereview.appspot.com/11781003 TBR=alexeypa@chromium.org BUG=104544, 169126 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -285 lines) Patch
M remoting/capturer/video_frame_capturer_fake.h View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/capturer/video_frame_capturer_fake.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/client_session.h View 3 chunks +10 lines, -4 lines 0 comments Download
MM remoting/host/client_session.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 11 chunks +146 lines, -231 lines 0 comments Download
M remoting/host/mouse_clamping_filter.h View 1 chunk +11 lines, -16 lines 0 comments Download
M remoting/host/mouse_clamping_filter.cc View 1 chunk +9 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alexeypa (please no reviews)
7 years, 11 months ago (2013-01-10 19:26:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698