Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1181703008: Removed webui_generator and new OOBE UI placeholder. (Closed)

Created:
5 years, 6 months ago by dzhioev (left Google)
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed webui_generator and new OOBE UI placeholder. As long as new OOBE is not going to be implemented anymore, webui_generator and new OOBE placeholder can be removed. BUG=none Committed: https://crrev.com/99949d7685baa13912a4cd759e45d712d8707329 Cr-Commit-Position: refs/heads/master@{#335356}

Patch Set 1 #

Patch Set 2 : Removed empty line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2919 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 4 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/chromeos/oobe/oobe.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/chromeos/oobe/oobe.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/BUILD.gn View 3 chunks +1 line, -5 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +0 lines, -1 line 0 comments Download
M components/resources/components_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D components/resources/webui_generator_resources.grdp View 1 chunk +0 lines, -7 lines 0 comments Download
D components/webui_generator.gypi View 1 chunk +0 lines, -37 lines 0 comments Download
D components/webui_generator/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
D components/webui_generator/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/webui_generator/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/webui_generator/data_source_util.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/webui_generator/data_source_util.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D components/webui_generator/export.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/webui_generator/generator/build_helper.py View 1 chunk +0 lines, -69 lines 0 comments Download
D components/webui_generator/generator/declaration.py View 1 chunk +0 lines, -312 lines 0 comments Download
D components/webui_generator/generator/export_h.py View 1 chunk +0 lines, -66 lines 0 comments Download
D components/webui_generator/generator/gen_sources.py View 1 chunk +0 lines, -27 lines 0 comments Download
D components/webui_generator/generator/html_view.py View 1 chunk +0 lines, -111 lines 0 comments Download
D components/webui_generator/generator/util.py View 1 chunk +0 lines, -30 lines 0 comments Download
D components/webui_generator/generator/view_model.py View 1 chunk +0 lines, -329 lines 0 comments Download
D components/webui_generator/generator/web_ui_view.py View 1 chunk +0 lines, -205 lines 0 comments Download
D components/webui_generator/generator/wug.gni View 1 chunk +0 lines, -131 lines 0 comments Download
D components/webui_generator/generator/wug.gypi View 1 chunk +0 lines, -117 lines 0 comments Download
D components/webui_generator/resources/context.html View 1 chunk +0 lines, -5 lines 0 comments Download
D components/webui_generator/resources/context.js View 1 chunk +0 lines, -21 lines 0 comments Download
D components/webui_generator/resources/webui-view.html View 1 chunk +0 lines, -10 lines 0 comments Download
D components/webui_generator/resources/webui-view.js View 1 chunk +0 lines, -189 lines 0 comments Download
D components/webui_generator/view.h View 1 chunk +0 lines, -118 lines 0 comments Download
D components/webui_generator/view.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D components/webui_generator/view_model.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/webui_generator/view_model.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D components/webui_generator/web_ui_view.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/webui_generator/web_ui_view.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D components/webui_generator_strings.grdp View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/login/display_manager.js View 2 chunks +0 lines, -3 lines 0 comments Download
D ui/oobe/BUILD.gn View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/oobe/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D ui/oobe/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D ui/oobe/declarations/oobe.json View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/oobe/oobe.gyp View 1 chunk +0 lines, -64 lines 0 comments Download
D ui/oobe/oobe_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/oobe/oobe_md_ui.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/oobe/oobe_md_ui.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/oobe/oobe_resources.grd View 1 chunk +0 lines, -22 lines 0 comments Download
D ui/oobe/resources/oobe-element.html View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/oobe/resources/oobe-element.js View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/oobe/resources/oobe_ui.html View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/oobe/resources/oobe_ui.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dzhioev (left Google)
Hello Brett, as discussed, I'm removing webui_generator from the repository. PTAL
5 years, 6 months ago (2015-06-18 04:10:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181703008/20001
5 years, 6 months ago (2015-06-18 04:13:20 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/7576)
5 years, 6 months ago (2015-06-18 06:25:39 UTC) #6
brettw
LGTM, thanks!
5 years, 6 months ago (2015-06-19 17:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181703008/20001
5 years, 6 months ago (2015-06-19 20:41:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 21:56:22 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 21:57:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99949d7685baa13912a4cd759e45d712d8707329
Cr-Commit-Position: refs/heads/master@{#335356}

Powered by Google App Engine
This is Rietveld 408576698