Refactoring: Move StyledMarkupAccumulator::createInlineStyle to the serializer

Refactoring: Move StyledMarkupAccumulator::createInlineStyle to the serializer

This CL moves the function appendStartTag/Markup and createInlineStyle
from StyledMarupAccumulator to StyledMarkupSerializer so that the
accumulator can focus on accumulation.

This CL is a split of crrev.com/1177323005/. StyledMarkupAccumulator::
wrappingStyled() is temporarily added and I plan to remove this.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197240

[hajimehoshi, 2015-06-16 11:58:13]

hajimehoshi@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[hajimehoshi, 2015-06-16 11:58:13]

PTAL

[tkent, 2015-06-16 22:27:00]

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.h (right):

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.h:58:
PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle() const { return
m_wrappingStyle; }
The return type should be |EditingStyle*|, or should change this function to
|copyWrappingStyle()| which returns a copy of m_wrappingStyle.
Without it, this change adds some extra instructions.

[yosin_UTC9, 2015-06-17 01:07:31]

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:348:
RefPtrWillBeRawPtr<EditingStyle> style = createInlineStyle(accumulator,
element);
nit: better to use |inlineStyle| rather than |style|.

[hajimehoshi, 2015-06-17 04:33:51]

Thank you!

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.h (right):

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.h:58:
PassRefPtrWillBeRawPtr<EditingStyle> wrappingStyle() const { return
m_wrappingStyle; }
On 2015/06/16 22:27:00, tkent wrote:
> The return type should be |EditingStyle*|, or should change this function to
> |copyWrappingStyle()| which returns a copy of m_wrappingStyle.
> Without it, this change adds some extra instructions.

Done.

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1181703003/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:348:
RefPtrWillBeRawPtr<EditingStyle> style = createInlineStyle(accumulator,
element);
On 2015/06/17 01:07:31, Yosi_UTC9 wrote:
> nit: better to use |inlineStyle| rather than |style|.

Done.

[tkent, 2015-06-17 04:41:22]

lgtm

[hajimehoshi, 2015-06-17 04:41:49]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2015-06-17 04:42:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181703003/40001

[commit-bot: I haz the power, 2015-06-17 05:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 05:01:59]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59186)

[hajimehoshi, 2015-06-17 06:15:15]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2015-06-17 06:15:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1181703003/#ps60001
(title: "bug fix: rebasing failed")

[commit-bot: I haz the power, 2015-06-17 06:15:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181703003/60001

[commit-bot: I haz the power, 2015-06-17 07:15:43]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197240