Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 11817022: [chromedriver] Add README (Closed)

Created:
7 years, 11 months ago by kkania
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Add a README file that contains helpful info about contributing to ChromeDriver. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175859

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A chrome/test/chromedriver/README.txt View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kkania
This was inspired from chrome/browser/extensions/api/README.txt, which I've found to be helpful. I think putting more ...
7 years, 11 months ago (2013-01-09 18:33:29 UTC) #1
craigdh
lgtm. Thanks for this!
7 years, 11 months ago (2013-01-09 18:41:23 UTC) #2
klundberg
Thanks, Ken! I personally like this idea and just have a few suggestions/comments to content ...
7 years, 11 months ago (2013-01-09 18:43:09 UTC) #3
frankf
lgtm
7 years, 11 months ago (2013-01-09 18:56:48 UTC) #4
kkania
https://codereview.chromium.org/11817022/diff/1/chrome/test/chromedriver/README.txt File chrome/test/chromedriver/README.txt (right): https://codereview.chromium.org/11817022/diff/1/chrome/test/chromedriver/README.txt#newcode15 chrome/test/chromedriver/README.txt:15: chromedriver.py. On 2013/01/09 18:43:09, klundberg wrote: > Maybe you ...
7 years, 11 months ago (2013-01-09 18:58:21 UTC) #5
chrisgao (Use stgao instead)
lgtm
7 years, 11 months ago (2013-01-09 19:02:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/11817022/8001
7 years, 11 months ago (2013-01-09 19:04:42 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 19:56:56 UTC) #8
Message was sent while issue was closed.
Change committed as 175859

Powered by Google App Engine
This is Rietveld 408576698