Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: src/ic.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code cleanup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 0db9aa56204afe81f556c53e86e90adfe5a9f083..b7e00eba89db4056c957881e01893b4a86aa4111 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1858,6 +1858,11 @@ Handle<Code> KeyedStoreIC::ComputePolymorphicStub(
Handle<Code> cached_stub;
Handle<Map> transitioned_map =
receiver_map->FindTransitionedMap(receiver_maps);
+
+ // TODO(mvstanton): we should set the transitioned map to always be
+ // null, and quit doing transitions on key stores. Right now though
+ // if I do this there are some serious performance issues.
+
if (!transitioned_map.is_null()) {
cached_stub = ElementsTransitionAndStoreStub(
receiver_map->elements_kind(), // original elements_kind

Powered by Google App Engine
This is Rietveld 408576698