src/x64/stub-cache-x64.cc - Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed MIPs changes, and found a bug. COPY_ON_WRITE shallow array stub didn't track allocation inf… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 82727ef14ece23c6cbf1ddb50e6cdc679a89c3a0..b7e3f3212d6e904f92e49ef43d920da246a4c968 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -1579,7 +1579,7 @@ Handle<Code> CallStubCompiler::CompileArrayPushCall(

&try_holey_map);

ElementsTransitionGenerator::

- GenerateMapChangeElementsTransition(masm());

+ GenerateMapChangeElementsTransition(masm(), NULL);

// Restore edi.

__ movq(rdi, FieldOperand(rdx, JSArray::kElementsOffset));

__ jmp(&fast_object);

@@ -1591,7 +1591,7 @@ Handle<Code> CallStubCompiler::CompileArrayPushCall(

rdi,

&call_builtin);

ElementsTransitionGenerator::

- GenerateMapChangeElementsTransition(masm());

+ GenerateMapChangeElementsTransition(masm(), NULL);

__ movq(rdi, FieldOperand(rdx, JSArray::kElementsOffset));

__ bind(&fast_object);

} else {

« src/objects.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/allocation-site-info.js » ('j') | no next file with comments »