src/ia32/stub-cache-ia32.cc - Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed MIPs changes, and found a bug. COPY_ON_WRITE shallow array stub didn't track allocation inf… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc

index 2129be3a874431a935e3feac003b67ff2d056919..539b292e12f033fd9864b284af1888726056a4c4 100644

--- a/src/ia32/stub-cache-ia32.cc

+++ b/src/ia32/stub-cache-ia32.cc

@@ -1616,7 +1616,7 @@ Handle<Code> CallStubCompiler::CompileArrayPushCall(

&try_holey_map);

ElementsTransitionGenerator::

- GenerateMapChangeElementsTransition(masm());

+ GenerateMapChangeElementsTransition(masm(), NULL);

// Restore edi.

__ mov(edi, FieldOperand(edx, JSArray::kElementsOffset));

__ jmp(&fast_object);

@@ -1628,7 +1628,7 @@ Handle<Code> CallStubCompiler::CompileArrayPushCall(

edi,

&call_builtin);

ElementsTransitionGenerator::

- GenerateMapChangeElementsTransition(masm());

+ GenerateMapChangeElementsTransition(masm(), NULL);

// Restore edi.

__ mov(edi, FieldOperand(edx, JSArray::kElementsOffset));

__ bind(&fast_object);

« src/ia32/lithium-codegen-ia32.cc ('K') | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic.cc » ('j') | src/objects.cc » ('J')