Additional work to get array literal allocation tracking working, even with --always-opt

src/code-stubs.cc

Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index c7d4c805d0c87824ecd1cbdb23afc49dfa710f02..d6a231cf1a1b5b6504a20330a41e6e07c36a90c4 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -575,7 +575,7 @@ void ElementsTransitionAndStoreStub::Generate(MacroAssembler* masm) {
     if (IsFastSmiOrObjectElementsKind(to_)) {
       if (IsFastSmiOrObjectElementsKind(from_)) {
         ElementsTransitionGenerator::
-            GenerateMapChangeElementsTransition(masm);
+            GenerateMapChangeElementsTransition(masm, &fail);
       } else if (IsFastDoubleElementsKind(from_)) {
         ASSERT(!IsFastSmiElementsKind(to_));
         ElementsTransitionGenerator::GenerateDoubleToObject(masm, &fail);
@@ -594,8 +594,11 @@ void ElementsTransitionAndStoreStub::Generate(MacroAssembler* masm) {
                                                              grow_mode_);
     } else if (IsFastDoubleElementsKind(from_)) {
       ASSERT(to_ == FAST_HOLEY_DOUBLE_ELEMENTS);
+      // Don't pass the fail label because we don't want to
+      // record allocation site info changes for the double->fast
+      // transition.

[mvstanton, 2013/01/11 16:56:06]

Better, pass a parameter to the method indicating track/don'ttrack
(AllocationSiteInfoMode). And in as many places as possible, discover this with
a helper method that hides:
1) the flag
2) to, from elements kind
3) other dynamic cases...e.tc.

[mvstanton, 2013/01/15 15:23:15]

I have added these methods, such that the on/off flag is controlled from a
central point, as well as the "business logic" of deciding whether a particular
(from,to) transition situation should be tracked or not.

       ElementsTransitionGenerator::
-          GenerateMapChangeElementsTransition(masm);
+          GenerateMapChangeElementsTransition(masm, NULL);
     } else {
       UNREACHABLE();
     }