src/arm/stub-cache-arm.cc - Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/stub-cache-arm.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed MIPs changes, and found a bug. COPY_ON_WRITE shallow array stub didn't track allocation inf… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/stub-cache-arm.cc

diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc

index dcc88f712d96e392a0142166b61123f201c0a22a..46b564b5cb87dcc2f094d527a3173b1644a3ac84 100644

--- a/src/arm/stub-cache-arm.cc

+++ b/src/arm/stub-cache-arm.cc

@@ -1694,7 +1694,7 @@ Handle<Code> CallStubCompiler::CompileArrayPushCall(

&try_holey_map);

__ mov(r2, receiver);

ElementsTransitionGenerator::

- GenerateMapChangeElementsTransition(masm());

+ GenerateMapChangeElementsTransition(masm(), NULL);

__ jmp(&fast_object);

__ bind(&try_holey_map);

@@ -1705,7 +1705,7 @@ Handle<Code> CallStubCompiler::CompileArrayPushCall(

&call_builtin);

__ mov(r2, receiver);

ElementsTransitionGenerator::

- GenerateMapChangeElementsTransition(masm());

+ GenerateMapChangeElementsTransition(masm(), NULL);

__ bind(&fast_object);

} else {

__ CheckFastObjectElements(r3, r3, &call_builtin);

« src/arm/code-stubs-arm.cc ('K') | « src/arm/lithium-codegen-arm.cc ('k') | src/code-stubs.h » ('j') | src/code-stubs.h » ('J')