Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code cleanup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 828 matching lines...) Expand 10 before | Expand all | Expand 10 after
839 __ mov(ebx, FieldOperand(edx, JSObject::kElementsOffset)); 839 __ mov(ebx, FieldOperand(edx, JSObject::kElementsOffset));
840 __ jmp(&fast_double_without_map_check); 840 __ jmp(&fast_double_without_map_check);
841 841
842 __ bind(&non_double_value); 842 __ bind(&non_double_value);
843 // Value is not a double, FAST_SMI_ELEMENTS -> FAST_ELEMENTS 843 // Value is not a double, FAST_SMI_ELEMENTS -> FAST_ELEMENTS
844 __ LoadTransitionedArrayMapConditional(FAST_SMI_ELEMENTS, 844 __ LoadTransitionedArrayMapConditional(FAST_SMI_ELEMENTS,
845 FAST_ELEMENTS, 845 FAST_ELEMENTS,
846 ebx, 846 ebx,
847 edi, 847 edi,
848 slow); 848 slow);
849 ElementsTransitionGenerator::GenerateMapChangeElementsTransition(masm); 849 ElementsTransitionGenerator::GenerateMapChangeElementsTransition(masm, slow);
850 __ mov(ebx, FieldOperand(edx, JSObject::kElementsOffset)); 850 __ mov(ebx, FieldOperand(edx, JSObject::kElementsOffset));
851 __ jmp(&finish_object_store); 851 __ jmp(&finish_object_store);
852 852
853 __ bind(&transition_double_elements); 853 __ bind(&transition_double_elements);
854 // Elements are FAST_DOUBLE_ELEMENTS, but value is an Object that's not a 854 // Elements are FAST_DOUBLE_ELEMENTS, but value is an Object that's not a
855 // HeapNumber. Make sure that the receiver is a Array with FAST_ELEMENTS and 855 // HeapNumber. Make sure that the receiver is a Array with FAST_ELEMENTS and
856 // transition array from FAST_DOUBLE_ELEMENTS to FAST_ELEMENTS 856 // transition array from FAST_DOUBLE_ELEMENTS to FAST_ELEMENTS
857 __ mov(ebx, FieldOperand(edx, HeapObject::kMapOffset)); 857 __ mov(ebx, FieldOperand(edx, HeapObject::kMapOffset));
858 __ LoadTransitionedArrayMapConditional(FAST_DOUBLE_ELEMENTS, 858 __ LoadTransitionedArrayMapConditional(FAST_DOUBLE_ELEMENTS,
859 FAST_ELEMENTS, 859 FAST_ELEMENTS,
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
1759 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1759 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1760 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1760 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1761 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1761 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1762 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1762 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1763 } 1763 }
1764 1764
1765 1765
1766 } } // namespace v8::internal 1766 } } // namespace v8::internal
1767 1767
1768 #endif // V8_TARGET_ARCH_IA32 1768 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698