Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code cleanup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/ic-arm.cc » ('j') | src/arm/lithium-codegen-arm.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 masm->set_has_frame(false); 137 masm->set_has_frame(false);
138 } 138 }
139 139
140 140
141 // ------------------------------------------------------------------------- 141 // -------------------------------------------------------------------------
142 // Code generators 142 // Code generators
143 143
144 #define __ ACCESS_MASM(masm) 144 #define __ ACCESS_MASM(masm)
145 145
146 void ElementsTransitionGenerator::GenerateMapChangeElementsTransition( 146 void ElementsTransitionGenerator::GenerateMapChangeElementsTransition(
147 MacroAssembler* masm) { 147 MacroAssembler* masm, Label* fail) {
danno 2013/01/10 22:58:59 nit: here and elsewhere it might be clearer if you
mvstanton 2013/01/11 13:43:01 Done.
148 // ----------- S t a t e ------------- 148 // ----------- S t a t e -------------
149 // -- r0 : value 149 // -- r0 : value
150 // -- r1 : key 150 // -- r1 : key
151 // -- r2 : receiver 151 // -- r2 : receiver
152 // -- lr : return address 152 // -- lr : return address
153 // -- r3 : target map, scratch for subsequent call 153 // -- r3 : target map, scratch for subsequent call
154 // -- r4 : scratch (elements) 154 // -- r4 : scratch (elements)
155 // ----------------------------------- 155 // -----------------------------------
156 if (FLAG_track_allocation_sites && fail != NULL) {
157 masm->TestJSArrayForAllocationSiteInfo(r2, r4, fail);
158 }
159
156 // Set transitioned map. 160 // Set transitioned map.
157 __ str(r3, FieldMemOperand(r2, HeapObject::kMapOffset)); 161 __ str(r3, FieldMemOperand(r2, HeapObject::kMapOffset));
158 __ RecordWriteField(r2, 162 __ RecordWriteField(r2,
159 HeapObject::kMapOffset, 163 HeapObject::kMapOffset,
160 r3, 164 r3,
161 r9, 165 r9,
162 kLRHasNotBeenSaved, 166 kLRHasNotBeenSaved,
163 kDontSaveFPRegs, 167 kDontSaveFPRegs,
164 EMIT_REMEMBERED_SET, 168 EMIT_REMEMBERED_SET,
165 OMIT_SMI_CHECK); 169 OMIT_SMI_CHECK);
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 patcher.masm()->add(r0, pc, Operand(-8)); 689 patcher.masm()->add(r0, pc, Operand(-8));
686 patcher.masm()->ldr(pc, MemOperand(pc, -4)); 690 patcher.masm()->ldr(pc, MemOperand(pc, -4));
687 patcher.masm()->dd(reinterpret_cast<uint32_t>(stub->instruction_start())); 691 patcher.masm()->dd(reinterpret_cast<uint32_t>(stub->instruction_start()));
688 } 692 }
689 } 693 }
690 694
691 695
692 } } // namespace v8::internal 696 } } // namespace v8::internal
693 697
694 #endif // V8_TARGET_ARCH_ARM 698 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/ic-arm.cc » ('j') | src/arm/lithium-codegen-arm.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698