Additional work to get array literal allocation tracking working, even with --always-opt

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4963 matching lines @@
 
   void SetEnumLength(int length) {
     if (length != kInvalidEnumCache) {
       ASSERT(length >= 0);
       ASSERT(length == 0 || instance_descriptors()->HasEnumCache());
       ASSERT(length <= NumberOfOwnDescriptors());
     }
     set_bit_field3(EnumLengthBits::update(bit_field3(), length));
   }
 
-
+  inline bool CanTrackAllocationSite();
   inline bool owns_descriptors();
   inline void set_owns_descriptors(bool is_shared);
   inline bool is_observed();
   inline void set_is_observed(bool is_observed);
 
   MUST_USE_RESULT MaybeObject* RawCopy(int instance_size);
   MUST_USE_RESULT MaybeObject* CopyWithPreallocatedFieldDescriptors();
   MUST_USE_RESULT MaybeObject* CopyDropDescriptors();
   MUST_USE_RESULT MaybeObject* CopyReplaceDescriptors(
       DescriptorArray* descriptors,
@@ skipping 1909 matching lines @@
   DISALLOW_IMPLICIT_CONSTRUCTORS(TypeFeedbackInfo);
 };
 
 
 enum AllocationSiteInfoMode {
   DONT_TRACK_ALLOCATION_SITE_INFO,
   TRACK_ALLOCATION_SITE_INFO
 };
 
 
+

[Toon Verwaest, 2013/01/16 10:53:42]

Trim empty lines down to 2.

[mvstanton, 2013/01/16 13:01:56]

Done.

+
 class AllocationSiteInfo: public Struct {
  public:
   DECL_ACCESSORS(payload, Object)
 
   static inline AllocationSiteInfo* cast(Object* obj);
 
   DECLARE_PRINTER(AllocationSiteInfo)
   DECLARE_VERIFIER(AllocationSiteInfo)
 
   // Returns NULL if no AllocationSiteInfo is available for object.
   static AllocationSiteInfo* FindForJSObject(JSObject* object);
 
+  static AllocationSiteInfoMode GetMode();

[Toon Verwaest, 2013/01/16 10:53:42]

Just use the flag if no other arguments are required.

[mvstanton, 2013/01/16 13:01:56]

Done.

+  static AllocationSiteInfoMode GetMode(ElementsKind boilerplate_elements_kind);
+  static AllocationSiteInfoMode GetMode(ElementsKind from, ElementsKind to);
+
   static const int kPayloadOffset = HeapObject::kHeaderSize;
   static const int kSize = kPayloadOffset + kPointerSize;
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AllocationSiteInfo);
 };
 
 
 // Representation of a slow alias as part of a non-strict arguments objects.
 // For fast aliases (if HasNonStrictArgumentsElements()):
@@ skipping 1891 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_