Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 11817017: Additional work to get array literal allocation tracking working, even with --always-opt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed MIPs changes, and found a bug. COPY_ON_WRITE shallow array stub didn't track allocation inf… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 383
384 #undef __ 384 #undef __
385 385
386 // ------------------------------------------------------------------------- 386 // -------------------------------------------------------------------------
387 // Code generators 387 // Code generators
388 388
389 #define __ ACCESS_MASM(masm) 389 #define __ ACCESS_MASM(masm)
390 390
391 391
392 void ElementsTransitionGenerator::GenerateMapChangeElementsTransition( 392 void ElementsTransitionGenerator::GenerateMapChangeElementsTransition(
393 MacroAssembler* masm) { 393 MacroAssembler* masm, Label* allocation_site_info_found) {
394 // ----------- S t a t e ------------- 394 // ----------- S t a t e -------------
395 // -- eax : value 395 // -- eax : value
396 // -- ebx : target map 396 // -- ebx : target map
397 // -- ecx : key 397 // -- ecx : key
398 // -- edx : receiver 398 // -- edx : receiver
399 // -- esp[0] : return address 399 // -- esp[0] : return address
400 // ----------------------------------- 400 // -----------------------------------
401 if (FLAG_track_allocation_sites &&
402 allocation_site_info_found != NULL) {
403 masm->TestJSArrayForAllocationSiteInfo(edx, edi,
404 allocation_site_info_found);
405 }
406
401 // Set transitioned map. 407 // Set transitioned map.
402 __ mov(FieldOperand(edx, HeapObject::kMapOffset), ebx); 408 __ mov(FieldOperand(edx, HeapObject::kMapOffset), ebx);
403 __ RecordWriteField(edx, 409 __ RecordWriteField(edx,
404 HeapObject::kMapOffset, 410 HeapObject::kMapOffset,
405 ebx, 411 ebx,
406 edi, 412 edi,
407 kDontSaveFPRegs, 413 kDontSaveFPRegs,
408 EMIT_REMEMBERED_SET, 414 EMIT_REMEMBERED_SET,
409 OMIT_SMI_CHECK); 415 OMIT_SMI_CHECK);
410 } 416 }
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
944 Code* stub = GetCodeAgeStub(age, parity); 950 Code* stub = GetCodeAgeStub(age, parity);
945 CodePatcher patcher(sequence, young_length); 951 CodePatcher patcher(sequence, young_length);
946 patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32); 952 patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32);
947 } 953 }
948 } 954 }
949 955
950 956
951 } } // namespace v8::internal 957 } } // namespace v8::internal
952 958
953 #endif // V8_TARGET_ARCH_IA32 959 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698