Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: tools/testing/dart/test_options.dart

Issue 11817012: Migration of testing scripts in tools/ to libv2 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 8f9232b4b66810dfe323bd2f417d42b2d7c504e2..fa2edd53c1c5fbcfe9261cad43ffafa5ed770837 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -368,7 +368,7 @@ Note: currently only implemented for dart2js.''',
configuration[spec.name] = true;
} else if (spec.type == 'int') {
try {
- configuration[spec.name] = parseInt(value);
+ configuration[spec.name] = int.parse(value);
} catch (e) {
print('Integer value expected for int option $name');
exit(1);
@@ -395,7 +395,7 @@ Note: currently only implemented for dart2js.''',
}
List<Map> expandedConfigs = _expandConfigurations(configuration);
- List<Map> result = expandedConfigs.filter(_isValidConfig);
+ List<Map> result = expandedConfigs.where(_isValidConfig).toList();
return result.isEmpty ? null : result;
}
@@ -665,7 +665,7 @@ Note: currently only implemented for dart2js.''',
*/
_TestOptionSpecification _getSpecification(String name) {
for (var option in _options) {
- if (option.keys.some((key) => key == name)) {
+ if (option.keys.any((key) => key == name)) {
return option;
}
}

Powered by Google App Engine
This is Rietveld 408576698