Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/test-runtime.dart

Issue 11817012: Migration of testing scripts in tools/ to libv2 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/test-runtime.dart
diff --git a/tools/test-runtime.dart b/tools/test-runtime.dart
index 05aac408f812c5963e35404bcfcec82711c2c8c2..95c24d4bad5147eaf0b557498ad43ef3df43bb09 100755
--- a/tools/test-runtime.dart
+++ b/tools/test-runtime.dart
@@ -64,19 +64,19 @@ main() {
List output_words = configurations.length > 1 ?
['Test configurations:'] : ['Test configuration:'];
for (Map conf in configurations) {
- List settings =
- ['compiler', 'runtime', 'mode', 'arch'].map((name) => conf[name]);
+ List settings = ['compiler', 'runtime', 'mode', 'arch']
+ .mappedBy((name) => conf[name]).toList();
if (conf['checked']) settings.add('checked');
output_words.add(Strings.join(settings, '_'));
}
print(Strings.join(output_words, ' '));
}
- var configurationIterator = configurations.iterator();
+ var configurationIterator = configurations.iterator;
void enqueueConfiguration(ProcessQueue queue) {
- if (!configurationIterator.hasNext) return;
+ if (!configurationIterator.moveNext()) return;
- var conf = configurationIterator.next();
+ var conf = configurationIterator.current;
if (selectors.containsKey('co19')) {
queue.addTestSuite(new Co19TestSuite(conf));
}
@@ -100,7 +100,7 @@ main() {
// test that needs to load resources from the repo over http.
if (!listTests) {
// Only start the server if we are running browser tests.
- var runningBrowserTests = configurations.some((config) {
+ var runningBrowserTests = configurations.any((config) {
return TestUtils.isBrowserRuntime(config['runtime']);
});
if (runningBrowserTests) startHttpServer('127.0.0.1', 9876);

Powered by Google App Engine
This is Rietveld 408576698