Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/testing/dart/drt_updater.dart

Issue 11817012: Migration of testing scripts in tools/ to libv2 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: added binaries Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/drt_updater.dart
diff --git a/tools/testing/dart/drt_updater.dart b/tools/testing/dart/drt_updater.dart
index e6645dfda2aaebbc99b8349c5966d6f9dcd1fb73..10d758abfcb7a2d61ee24e03a05532fbe6f3cd19 100644
--- a/tools/testing/dart/drt_updater.dart
+++ b/tools/testing/dart/drt_updater.dart
@@ -4,6 +4,7 @@
library drt_updater;
+import "dart:async";
import "dart:io";
import "test_suite.dart";
@@ -27,7 +28,7 @@ class _DartiumUpdater {
print('Updating $name.');
onUpdated = [() {updated = true;} ];
_updatingProcess = Process.run('python', _getUpdateCommand);
- _updatingProcess.handleException((e) {
+ _updatingProcess.catchError((e) {
print("Error starting $script process: $e");
return false;
});
Bill Hesse 2013/01/09 17:06:33 Need to use the return value of catchError, not th
kustermann 2013/01/09 18:02:25 Done.

Powered by Google App Engine
This is Rietveld 408576698