Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 11817009: Fix overlay.css so close button is on top of the page. (Closed)

Created:
7 years, 11 months ago by achuithb
Modified:
7 years, 11 months ago
Reviewers:
xiyuan, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix overlay.css so close button is on top of the page. BUG=168424 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175940

Patch Set 1 #

Patch Set 2 : dbeam #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/shared/css/overlay.css View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
This may be a bug in the css: http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/resources/shared/css/overlay.css&l=96 If I leave out the h1 ...
7 years, 11 months ago (2013-01-09 00:31:14 UTC) #1
Dan Beam
how about: .overlay .page { z-index: 0; } .close-button { z-index: 1; } ? that ...
7 years, 11 months ago (2013-01-09 02:40:49 UTC) #2
achuithb
Dan: I've done as you suggest, and it works. PTAL. Could you explain why it ...
7 years, 11 months ago (2013-01-09 08:51:02 UTC) #3
achuithb
On 2013/01/09 08:51:02, achuith.bhandarkar wrote: > Dan: I've done as you suggest, and it works. ...
7 years, 11 months ago (2013-01-09 18:38:19 UTC) #4
xiyuan
LGTM
7 years, 11 months ago (2013-01-09 18:39:05 UTC) #5
Dan Beam
7 years, 11 months ago (2013-01-10 00:12:43 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698