Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1181643007: Fix regression in unwinding overallocation on auto cells (Closed)

Created:
4 years, 10 months ago by rhogan
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix regression in unwinding overallocation on auto cells In https://codereview.chromium.org/1111443003 we started bailing early if about to overallocate on auto and fixed width columns. The shrink width algorithm wasn't getting the correct parameters for either of these width types, so our behaviour when overallocating auto columns regressed. Fix the parameters passed to the shrink width algorithm so that it works as expected for auto columns when we have bailed out from allocating width early. Restore the old behaviour for fixed width columns and work out how to fix it in a separate patch. BUG=498165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
A LayoutTests/fast/table/overallocating-auto-cells.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/overallocating-auto-cells-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/layout/TableLayoutAlgorithmAuto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/TableLayoutAlgorithmAuto.cpp View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rhogan
4 years, 10 months ago (2015-06-14 11:42:41 UTC) #2
mstensho (USE GERRIT)
Need to find a consistent and clean solution, but getting rid of the regression is ...
4 years, 10 months ago (2015-06-15 07:25:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181643007/1
4 years, 10 months ago (2015-06-15 17:30:36 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 18:37:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197131

Powered by Google App Engine
This is Rietveld 408576698