Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1181633005: Convert PictureRenderer to SkPaintFilterCanvas (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert PictureRenderer to SkPaintFilterCanvas This removes the last client of SkDrawFilter. BUG=skia:3587 R=mtklein@google.com,robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/5042020d012cf1472312eecfcca6dcb754d7613e

Patch Set 1 #

Patch Set 2 : misc cleanup #

Patch Set 3 : missing 'override' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -21 lines) Patch
M tools/PictureRenderer.h View 3 chunks +8 lines, -1 line 0 comments Download
M tools/PictureRenderer.cpp View 1 2 6 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
f(malita)
5 years, 6 months ago (2015-06-15 18:31:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181633005/20001
5 years, 6 months ago (2015-06-15 18:31:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 18:36:19 UTC) #5
robertphillips
lgtm
5 years, 6 months ago (2015-06-15 18:38:16 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181633005/40001
5 years, 6 months ago (2015-06-15 18:41:48 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 18:46:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181633005/40001
5 years, 6 months ago (2015-06-15 18:47:46 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 18:48:20 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5042020d012cf1472312eecfcca6dcb754d7613e

Powered by Google App Engine
This is Rietveld 408576698