chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc - Issue 1181623004: [Password Manager] Replace "this site" in save password prompt with password's origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

Issue 1181623004: [Password Manager] Replace "this site" in save password prompt with password's origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate.cc ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.cc » ('j') | chrome/browser/ui/passwords/manage_passwords_view_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc b/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

index 70acca54e6206b0d2df5ccc4f7255b21274cda93..dbd8aa31baba5a102f032653a8e3b85bda7dd7ac 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

@@ -37,7 +37,8 @@ class TestSavePasswordInfobarDelegate : public SavePasswordInfoBarDelegate {

TestSavePasswordInfobarDelegate(

scoped_ptr<password_manager::PasswordFormManager> form_to_save,

password_manager::CredentialSourceType source_type)

- : SavePasswordInfoBarDelegate(form_to_save.Pass(),

+ : SavePasswordInfoBarDelegate(nullptr,

vivekg 2015/06/23 14:38:01 Should we have a detailed test which verifies the

Pritam Nikam 2015/06/25 08:59:14 I've removed WebCotents dependency. Moreover, adde

+ form_to_save.Pass(),

std::string(),

source_type,

true /* is_smartlock_branding_enabled */) {}