[Password Manager] Replace "this site" in save password prompt with password's origin.

chrome/browser/ui/passwords/manage_passwords_view_utils.h

Index: chrome/browser/ui/passwords/manage_passwords_view_utils.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils.h b/chrome/browser/ui/passwords/manage_passwords_view_utils.h
index 89757ca386d01ccab9a22d215f8b4982001c9310..7f53c15d419aa8c90495e17d93dbf68b575630e8 100644
--- a/chrome/browser/ui/passwords/manage_passwords_view_utils.h
+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils.h
@@ -5,13 +5,36 @@
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_VIEW_UTILS_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_VIEW_UTILS_H_
 
+#include "base/strings/string16.h"
+
 namespace gfx {
 class ImageSkia;
+class Range;
 }  // namespace gfx
 
+class GURL;
+
 // The desired width and height in pixels for an account avatar.
 extern const int kAvatarImageSize;
 
 // Crops and scales |image_skia| to the desired size for an account avatar.
 gfx::ImageSkia ScaleImageForAccountAvatar(gfx::ImageSkia image_skia);
+
+// This function sets formatted |tilte| in the "Save Password" dialog bubble. If

[palmer, 2015/06/26 17:59:58]

Typo: |title|

Nit: Wording. Try something like: "Sets the formatted |title| in the Save
Password bubble."

[Pritam Nikam, 2015/06/27 10:10:03]

Done.

+// the registry controlled domain of |user_visible_url| (i.e. the one seen in
+// the omnibox) differs from the registry controlled domain of
+// |form_origin_url|, sets resource string |IDS_SAVE_PASSWORD_TITLE| as the
+// |title| so that it replaces "this site" in title text with output of
+// |FormatUrlForSecurityDisplay(form_origin_url)|; otherwise sets resource

[palmer, 2015/06/26 17:59:58]

Nit: I'd start a new sentence here; and, you can be a bit more concise.
"...|FormatUrlForSecurityDisplay(form_origin_url)|. Otherwise, sets
|IDS_SAVE_PASSWORD| as the..."

[Pritam Nikam, 2015/06/27 10:10:03]

Done.

+// string |IDS_SAVE_PASSWORD| as the |title| having "this site". If
+// |is_smartlock_branding_enabled| is true sets the |title_link_range| for the
+// "Google Smart Lock" text range to be set visibly as a hyperlink in the dialog
+// bubble.
+void GetSavePasswordDialogTitleTextAndLinkRange(
+    const GURL& user_visible_url,
+    const GURL& form_origin_url,
+    bool is_smartlock_branding_enabled,
+    base::string16* title,
+    gfx::Range* title_link_range);
+
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_VIEW_UTILS_H_