build/android/gyp/write_build_config.py - Issue 1181613005: Extend unknown_deps for build_configs exemption to android_resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/write_build_config.py

Issue 1181613005: Extend unknown_deps for build_configs exemption to android_resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn2

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/write_build_config.py

diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py

index 8507a95d0b982808d5ca08eb12a6a86aa0a55d73..3773e98bc70beeb6c154774c395a31999a85b009 100755

--- a/build/android/gyp/write_build_config.py

+++ b/build/android/gyp/write_build_config.py

@@ -181,7 +181,8 @@ def main(argv):

possible_deps_config_paths = build_utils.ParseGypList(

options.possible_deps_configs)

- allow_unknown_deps = options.type == 'android_apk'

+ allow_unknown_deps = (options.type == 'android_apk' or

+ options.type == 'android_resources')

unknown_deps = [

c for c in possible_deps_config_paths if not os.path.exists(c)]

if unknown_deps and not allow_unknown_deps:

« no previous file with comments | « no previous file | no next file » | no next file with comments »