Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1181613005: Extend unknown_deps for build_configs exemption to android_resources. (Closed)

Created:
5 years, 6 months ago by Yaron
Modified:
5 years, 6 months ago
Reviewers:
cjhopman, Dirk Pranke
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend unknown_deps for build_configs exemption to android_resources. Previously only apks were eligible, but both can depend on an AndroidManifest which doesn't write a build config. BUG=500587 Committed: https://crrev.com/29d8e3b989cb4938640639ce90de488e5ca90c12 Cr-Commit-Position: refs/heads/master@{#335187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/gyp/write_build_config.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Yaron
Don't know if this is the ideal fix but appears to work locally
5 years, 6 months ago (2015-06-18 21:58:45 UTC) #2
Yaron
On 2015/06/18 21:58:45, Yaron wrote: > Don't know if this is the ideal fix but ...
5 years, 6 months ago (2015-06-18 22:11:17 UTC) #3
Dirk Pranke
On 2015/06/18 22:11:17, Yaron wrote: > On 2015/06/18 21:58:45, Yaron wrote: > > Don't know ...
5 years, 6 months ago (2015-06-18 22:12:35 UTC) #4
cjhopman
On 2015/06/18 22:12:35, Dirk Pranke wrote: > On 2015/06/18 22:11:17, Yaron wrote: > > On ...
5 years, 6 months ago (2015-06-18 22:46:17 UTC) #5
Dirk Pranke
(I fixed a couple typos in the CL subject and description).
5 years, 6 months ago (2015-06-18 22:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181613005/1
5 years, 6 months ago (2015-06-18 22:51:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 01:19:51 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 01:20:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29d8e3b989cb4938640639ce90de488e5ca90c12
Cr-Commit-Position: refs/heads/master@{#335187}

Powered by Google App Engine
This is Rietveld 408576698