Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1181603003: Revert of Revert of Revert of Promise assimilation fix. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/1181533006/) Reason for revert: [Sheriff] Changes/breaks layout tests. Please land upstream needsmanualrebaseline requests first or fix the tests. E.g. http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/400 One test fails, one times out. See e.g. expectations changes: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/400/layout-test-results/inspector/sources/debugger-async/async-callstack-promises-diff.txt On linux debug theses tests crash: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/346 https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/346/layout-test-results/results.html Original issue's description: > Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/1176163004/) > > Reason for revert: > Test failures are bogus. Snapshot blob and natives blob are out of sync due to build being weird. > > Original issue's description: > > Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/1098663002/) > > > > Reason for revert: > > Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829 > > > > Original issue's description: > > > Promise assimilation fix. > > > > > > Let x be a fulfilled promise and y be another promise. |x.then(() => y)| > > > should call |y.then|, but the current implementation calls PromiseChain. > > > We can see the difference when we set a custom function to |y.then|. > > > > > > This CL fixes the spec violation, but as a result |then| is no longer > > > a wrapper of |chain| and in some cases it does not work well with > > > |accept| or |chain|. That is not a problem for ES6 promise users because > > > ES6 promise doesn't have them. > > > > > > LOG=N > > > BUG=477921 > > > > > > Committed: https://crrev.com/2f57dff3ea0c45e1a61b334fda962460f89d71bc > > > Cr-Commit-Position: refs/heads/master@{#28926} > > > > TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=477921 > > > > Committed: https://crrev.com/5bb75f514027f79303396dba823c2d78c6add83b > > Cr-Commit-Position: refs/heads/master@{#28927} > > TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=477921 > > Committed: https://crrev.com/6f214bdd8bcdc76d48bd85c3bd897f0e2427ff95 > Cr-Commit-Position: refs/heads/master@{#28928} TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477921 Committed: https://crrev.com/4e7990d394b3297d7ecd47746e21989131dac11a Cr-Commit-Position: refs/heads/master@{#28931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -231 lines) Patch
M src/promise.js View 6 chunks +40 lines, -78 lines 0 comments Download
M test/mjsunit/es6/promises.js View 2 chunks +0 lines, -153 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of Revert of Promise assimilation fix.
5 years, 6 months ago (2015-06-11 09:08:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181603003/1
5 years, 6 months ago (2015-06-11 09:08:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 09:09:09 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 09:09:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e7990d394b3297d7ecd47746e21989131dac11a
Cr-Commit-Position: refs/heads/master@{#28931}

Powered by Google App Engine
This is Rietveld 408576698