Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1181593006:
Ignore autogenerated file (Closed)
|
Created:
5 years, 6 months ago by Peter Kasting Modified:
5 years, 6 months ago Reviewers:
Dirk Pranke CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionIgnore autogenerated file
BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197285
Patch Set 1 #
Messages
Total messages: 11 (2 generated)
pkasting@chromium.org changed reviewers: + dpranke@chromium.org
This should go in the top-level .gitignore file instead; having multiple .gitignores per repo can slow things down and so it is considered bad style to do so. Plus, it helps to have everything in one place. (not that the speed is likely to matter in this case). I don't see this file in my checkouts; maybe it is only generated in the msvs-ninja case, which I'm assuming you are using? the basic idea is fine, though. It's really a bug that a temp file is generated into the checkout, but msvs does this from time to time and it's probably not worth cleaning it up until we move to GN.
On 2015/06/17 19:29:45, Dirk Pranke wrote: > This should go in the top-level .gitignore file instead; having multiple > .gitignores per repo can slow things down and so it is considered bad style to > do so. Plus, it helps to have everything in one place. The top-level .gitignore explicitly says the opposite: # For best performance, place rules for deep paths in the parent directory. # For example: instead of placing Source/WebKit/chromium/WebKit.xcodeproj here, # place WebKit.xcodeproj in Source/WebKit/chromium/.gitignore Is this wrong and should be removed, then? > I don't see this file in my checkouts; maybe it is only generated in the > msvs-ninja case, which I'm assuming you are using? I only ran ninja in this checkout.
On 2015/06/17 19:46:26, Peter Kasting wrote: > On 2015/06/17 19:29:45, Dirk Pranke wrote: > > This should go in the top-level .gitignore file instead; having multiple > > .gitignores per repo can slow things down and so it is considered bad style to > > do so. Plus, it helps to have everything in one place. > > The top-level .gitignore explicitly says the opposite: > > # For best performance, place rules for deep paths in the parent directory. > # For example: instead of placing Source/WebKit/chromium/WebKit.xcodeproj here, > # place WebKit.xcodeproj in Source/WebKit/chromium/.gitignore > > Is this wrong and should be removed, then? Oh. Hm. Maybe I'm misremembering. > > > I don't see this file in my checkouts; maybe it is only generated in the > > msvs-ninja case, which I'm assuming you are using? > > I only ran ninja in this checkout. On what platform?
On 2015/06/17 20:46:33, Dirk Pranke wrote: > On 2015/06/17 19:46:26, Peter Kasting wrote: > > Is this wrong and should be removed, then? > > Oh. Hm. Maybe I'm misremembering. I guess I'm wrong; I see we have them scattered all over the tree.
On 2015/06/17 20:46:33, Dirk Pranke wrote: > On 2015/06/17 19:46:26, Peter Kasting wrote: > > On 2015/06/17 19:29:45, Dirk Pranke wrote: > > > This should go in the top-level .gitignore file instead; having multiple > > > .gitignores per repo can slow things down and so it is considered bad style > to > > > do so. Plus, it helps to have everything in one place. > > > > The top-level .gitignore explicitly says the opposite: > > > > # For best performance, place rules for deep paths in the parent directory. > > # For example: instead of placing Source/WebKit/chromium/WebKit.xcodeproj > here, > > # place WebKit.xcodeproj in Source/WebKit/chromium/.gitignore > > > > Is this wrong and should be removed, then? > > Oh. Hm. Maybe I'm misremembering. > > > > > > I don't see this file in my checkouts; maybe it is only generated in the > > > msvs-ninja case, which I'm assuming you are using? > > > > I only ran ninja in this checkout. > > On what platform? This is a new Windows setup. Unless somehow I launched MSVC and forgot about it. It's possible... Anyway, is this change OK?
On 2015/06/17 20:53:07, Peter Kasting wrote: > On 2015/06/17 20:46:33, Dirk Pranke wrote: > > On 2015/06/17 19:46:26, Peter Kasting wrote: > > > On 2015/06/17 19:29:45, Dirk Pranke wrote: > > > > This should go in the top-level .gitignore file instead; having multiple > > > > .gitignores per repo can slow things down and so it is considered bad > style > > to > > > > do so. Plus, it helps to have everything in one place. > > > > > > The top-level .gitignore explicitly says the opposite: > > > > > > # For best performance, place rules for deep paths in the parent directory. > > > # For example: instead of placing Source/WebKit/chromium/WebKit.xcodeproj > > here, > > > # place WebKit.xcodeproj in Source/WebKit/chromium/.gitignore > > > > > > Is this wrong and should be removed, then? > > > > Oh. Hm. Maybe I'm misremembering. > > > > > > > > > I don't see this file in my checkouts; maybe it is only generated in the > > > > msvs-ninja case, which I'm assuming you are using? > > > > > > I only ran ninja in this checkout. > > > > On what platform? > > This is a new Windows setup. > > Unless somehow I launched MSVC and forgot about it. It's possible... > > Anyway, is this change OK? Yup. I was going to do a build to check and see if I see it or not, but it's fine to land in the meantime. lgtm.
The CQ bit was checked by pkasting@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181593006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197285 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
