Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 1181573010: ServiceWorker: Fix matching registration info missing during shift-reload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iterate living registrations Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index 878aa2a933cbc1861b365e5929479795d753ebab..d17d2f7f52effa28901aeb0f3a5e0e7e8a4957ed 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -307,6 +307,19 @@ ServiceWorkerProviderHost::MatchRegistration() const {
return nullptr;
}
+void ServiceWorkerProviderHost::CopyMatchingRegistrations() {
+ DCHECK(context_);
+ const std::map<int64, ServiceWorkerRegistration*>& registrations =
+ context_->GetLiveRegistrations();
+ for (auto& key_registration : registrations) {
falken 2015/06/24 02:24:26 nit: extra space. (i just always use "git-cl forma
michaeln 2015/06/24 19:47:22 does const auto& work?
xiang 2015/06/25 05:37:32 Done.
xiang 2015/06/25 05:37:32 Done.
+ ServiceWorkerRegistration* registration = key_registration.second;
+ if (!registration->is_uninstalled() &&
+ ServiceWorkerUtils::ScopeMatches(registration->pattern(),
+ document_url_))
+ AddMatchingRegistration(registration);
+ }
+}
+
void ServiceWorkerProviderHost::NotifyControllerLost() {
SetControllerVersionAttribute(nullptr, true /* notify_controllerchange */);
}

Powered by Google App Engine
This is Rietveld 408576698