ServiceWorker: Fix matching registration info missing during shift-reload.

content/browser/service_worker/service_worker_request_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_request_handler.h"
 
 #include <string>
 
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 #include "content/browser/service_worker/service_worker_provider_host.h"
 #include "content/browser/service_worker/service_worker_registration.h"
 #include "content/browser/service_worker/service_worker_url_request_job.h"
 #include "content/browser/service_worker/service_worker_utils.h"
 #include "content/common/resource_request_body.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/browser/resource_context.h"
+#include "net/base/load_flags.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_interceptor.h"
 #include "storage/browser/blob/blob_storage_context.h"
 
 namespace content {
 
 namespace {
 
 int kUserDataKey;  // Key value is not important.
@@ skipping 45 matching lines @@
 
   ServiceWorkerProviderHost* provider_host =
       context_wrapper->context()->GetProviderHost(process_id, provider_id);
   if (!provider_host || !provider_host->IsContextAlive())
     return;
 
   if (skip_service_worker) {
     if (ServiceWorkerUtils::IsMainResourceType(resource_type)) {
       provider_host->SetDocumentUrl(net::SimplifyUrlForRequest(request->url()));
       provider_host->SetTopmostFrameUrl(request->first_party_for_cookies());
+      if (request->load_flags() & net::LOAD_BYPASS_CACHE)

[falken, 2015/06/22 06:04:02]

I'm a bit worried we're adding this if() without being sure of the possible
states, which will lead to difficult to maintain code.

If |skip_service_worker| without |LOAD_BYPASS_CACHE| is possible, it seems we we
still need to add matching registrations for that case. If it's not possible, we
should be able to add a DCHECK() and a comment "skip_service_worker means
shift-refresh, so copy from the old host" or somehting.

But, it looks like |skip_service_worker| can also come form devtool's "Disable
cache", which is why we added |skip_service_worker| in the first place:
https://chromium.googlesource.com/chromium/src/+/258fc42376fc25bb4fdfbc372ce5....
In which case there may not necessarily be an old provider host to copy from.

I think it might just be OK to add a possibly slower AddMatchingRegistrations,
and later on optimize it for shift-refresh case if warranted.

[xiang, 2015/06/23 09:01:36]

I changed to iterate all live registrations and made a DCHECK for
LOAD_BYPASS_CACHE flag with new getters in context core.

If I understand correctly, devtool "disable cache" will not set
skip_service_worker, instead it will set LOAD_BYPASS_CACHE flag. So we will only
copy registrations for shift-reload.

+        provider_host->CopyMatchingRegistrations();
     }
     return;
   }
 
   scoped_ptr<ServiceWorkerRequestHandler> handler(
       provider_host->CreateRequestHandler(request_mode,
                                           credentials_mode,
                                           resource_type,
                                           request_context_type,
                                           frame_type,
@@ skipping 70 matching lines @@
     ResourceType resource_type)
     : context_(context),
       provider_host_(provider_host),
       blob_storage_context_(blob_storage_context),
       resource_type_(resource_type),
       old_process_id_(0),
       old_provider_id_(kInvalidServiceWorkerProviderId) {
 }
 
 }  // namespace content