Set error on WebDataConsumerHandle while loading body.

content/child/shared_memory_data_consumer_handle.h

Index: content/child/shared_memory_data_consumer_handle.h
diff --git a/content/child/shared_memory_data_consumer_handle.h b/content/child/shared_memory_data_consumer_handle.h
index 188d028e2e399f1c4bc4cdf20757c0daf58a4907..bedced0ecf1cea2874e2727d1c48c195a48332a6 100644
--- a/content/child/shared_memory_data_consumer_handle.h
+++ b/content/child/shared_memory_data_consumer_handle.h
@@ -29,8 +29,12 @@ class CONTENT_EXPORT SharedMemoryDataConsumerHandle final
    public:
     Writer(const scoped_refptr<Context>& context, BackpressureMode mode);
     ~Writer();
+    // Note: We assume |AddData| is not called in a client's didGetReadable

[kinuko, 2015/06/22 06:39:27]

nit: this comment is a bit ambiguous, who's 'we' and who's expected to guarantee
the assumption?

[yhirano, 2015/06/22 07:08:13]

Fixed: Writer assumes that / A caller should ensure that.

+    // callback. There isn't such assumption for |Close| and |Error|.
     void AddData(scoped_ptr<RequestPeer::ReceivedData> data);
     void Close();
+    // TODO(yhirano): Consider providing error code.
+    void Error();

[kinuko, 2015/06/22 06:39:27]

nit: it's subjective but 'error' sounds more like noun than verb, Fail() or
OnError() would be slightly more common

[yhirano, 2015/06/22 07:08:13]

Done.

 
    private:
     scoped_refptr<Context> context_;
@@ -61,20 +65,10 @@ class CONTENT_EXPORT SharedMemoryDataConsumerHandle final
 
   scoped_ptr<Reader> ObtainReader(Client* client);
 
-  virtual Result read(void* data, size_t size, Flags flags, size_t* readSize);
-  virtual Result beginRead(const void** buffer, Flags flags, size_t* available);
-  virtual Result endRead(size_t readSize);
-  virtual void registerClient(Client* client);
-  virtual void unregisterClient();
-
  private:
   virtual ReaderImpl* obtainReaderInternal(Client* client);
-  void LockImplicitly();
-  void UnlockImplicitly();
 
   scoped_refptr<Context> context_;
-  // This is an implicitly acquired reader for deprecated APIs.
-  scoped_ptr<Reader> reader_;
 
   DISALLOW_COPY_AND_ASSIGN(SharedMemoryDataConsumerHandle);
 };