Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1181533002: Rename BlockContainer, StackContainer, and FlexContainer (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie, jackson
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename BlockContainer, StackContainer, and FlexContainer These are now called Block, Stack, and Flex, respectively. Less verbose. R=jackson@google.com, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8f1a16d95632e7adf91b7053f4620f6c06b9c76e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -64 lines) Patch
M sky/examples/fn2/container.dart View 1 chunk +11 lines, -12 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/drawer.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 2 chunks +8 lines, -15 lines 0 comments Download
M sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/input.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/modal_overlay.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-10 22:29:56 UTC) #1
jackson
lgtm
5 years, 6 months ago (2015-06-10 22:31:42 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 8f1a16d95632e7adf91b7053f4620f6c06b9c76e (presubmit successful).
5 years, 6 months ago (2015-06-10 22:34:34 UTC) #4
Hixie
5 years, 6 months ago (2015-06-10 22:36:07 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698