Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6555)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1181493002: [Patch 3 of 6] Split out content/child's SiteIsolationPolicy into two new classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename_policy_to_sniffer2
Patch Set: Yet more comment fixes. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 8e92c8deaa7e95eefba33ea8def390f3e8896214..ba501ac9c1f032d1410563808f2ed500f255a578 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1535,12 +1535,10 @@ bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(
#endif
}
-bool ChromeContentRendererClient::ShouldEnableSiteIsolationPolicy() const {
- // SiteIsolationPolicy is off by default. We would like to activate cross-site
- // document blocking (for UMA data collection) for normal renderer processes
- // running a normal web page from the Internet. We only turn on
- // SiteIsolationPolicy for a renderer process that does not have the extension
- // flag on.
+bool ChromeContentRendererClient::ShouldGatherSiteIsolationStats() const {
+ // Site isolation stats are gathered currently for non-extension renderer
+ // processes running a normal web page from the Internet.
+ // TODO(nick): Gather stats for extension processes too.
#if defined(ENABLE_EXTENSIONS)
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
return !command_line->HasSwitch(extensions::switches::kExtensionProcess);

Powered by Google App Engine
This is Rietveld 408576698