Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: Source/devtools/front_end/audits/AuditLauncherView.js

Issue 1181483004: Regression: Checkboxes doesn't work properly under 'Audits' section of 'DevTools' (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/audits/AuditLauncherView.js
diff --git a/Source/devtools/front_end/audits/AuditLauncherView.js b/Source/devtools/front_end/audits/AuditLauncherView.js
index df60449b3b33d0f2c00234fbb6edb9b3607875ad..7487eeb8793d04f5fcd734e0d6a2259a922dd3c6 100644
--- a/Source/devtools/front_end/audits/AuditLauncherView.js
+++ b/Source/devtools/front_end/audits/AuditLauncherView.js
@@ -293,7 +293,7 @@ WebInspector.AuditLauncherView.prototype = {
var selectedCategories = userGesture ? {} : this._selectedCategoriesSetting.get();
var childNodes = this._categoriesElement.childNodes;
for (var i = 0, length = childNodes.length; i < length; ++i)
- selectedCategories[childNodes[i].__displayName] = childNodes[i].firstChild.checked;
+ selectedCategories[childNodes[i].__displayName] = childNodes[i].checkboxElement.checked;
selectedCategories[WebInspector.AuditLauncherView.AllCategoriesKey] = this._selectAllCheckboxElement.checked;
this._selectedCategoriesSetting.set(selectedCategories);
this._updateButton();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698