Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1181413009: move KeyUsageAllows to more logical place(part2) (Closed)

Created:
5 years, 6 months ago by Olli Raula
Modified:
5 years, 3 months ago
Reviewers:
eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

move KeyUsageAllows to more logical place(part2) move KeyUsageAllows to the class where its data is. That way the function and its contexts is much more understandable. This is second part, first part can be found here: https://crrev.com/1184123007/ Committed: https://crrev.com/af8abe5441c73f0e4a97784a918f9cbdb47d1aa5 Cr-Commit-Position: refs/heads/master@{#345818}

Patch Set 1 #

Patch Set 2 : ToT and AUTHORS #

Patch Set 3 : Fixed because changes in part 1 #

Patch Set 4 : Remove AUTHORS change because name is already there #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M components/webcrypto/algorithm_dispatch.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M components/webcrypto/webcrypto_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/webcrypto/webcrypto_util.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
eroman
lgtm
5 years, 4 months ago (2015-08-11 17:03:20 UTC) #2
eroman
I expect this can be submitted now that part 1 has landed
5 years, 3 months ago (2015-08-27 02:06:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181413009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1181413009/60001
5 years, 3 months ago (2015-08-27 06:23:45 UTC) #6
Olli Raula
Yes, thanks :)
5 years, 3 months ago (2015-08-27 06:23:51 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-27 09:03:22 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 09:04:23 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/af8abe5441c73f0e4a97784a918f9cbdb47d1aa5
Cr-Commit-Position: refs/heads/master@{#345818}

Powered by Google App Engine
This is Rietveld 408576698