reflectable/lib/src/mirrors_unimpl.dart - Issue 1181413005: Implement newInstance in the transformer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: reflectable/lib/src/mirrors_unimpl.dart

Issue 1181413005: Implement newInstance in the transformer. (Closed) Base URL: https://github.com/dart-lang/reflectable.git@master

Patch Set: Address review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: reflectable/lib/src/mirrors_unimpl.dart

diff --git a/reflectable/lib/src/mirrors_unimpl.dart b/reflectable/lib/src/mirrors_unimpl.dart

index c82dcff549b2b01c1487a9c68768309dc7a154e6..574a1d5d818443cab1b0ef027e825b151cf6c489 100644

--- a/reflectable/lib/src/mirrors_unimpl.dart

+++ b/reflectable/lib/src/mirrors_unimpl.dart

@@ -180,9 +180,8 @@ class MethodMirrorImpl implements MethodMirror {

@override

String get constructorName => name;

- // We do not support reflection on abstract methods.

@override

- bool get isAbstract => 0 != descriptor & constants.abstractAttribute;

+ bool get isAbstract => 0 != descriptor & constants.abstractAttribute;

@override

bool get isConstConstructor => 0 != descriptor & constants.constAttribute;

« no previous file with comments | « no previous file | reflectable/lib/src/transformer_implementation.dart » ('j') | no next file with comments »