test_reflectable/.status - Issue 1181413005: Implement newInstance in the transformer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test_reflectable/.status

Issue 1181413005: Implement newInstance in the transformer. (Closed) Base URL: https://github.com/dart-lang/reflectable.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 [ $compiler == dart2js ]	1 [ $compiler == dart2js ]

2 test/declarations_test: RuntimeError # Dart2js does not implement all properties of mirrors.	2 test/declarations_test: RuntimeError # Dart2js does not implement all properties of mirrors.

	3 test/new_instance_test: RuntimeError # dartbug.com/19635
	eernst 2015/06/18 13:35:41 Maybe separate the tests into the cases that will Maybe separate the tests into the cases that will work and the cases affected by dartbug.com/19635, such that we can run as much as possible? sigurdm 2015/06/19 07:50:54 I don't want to spend too much time on supporting Show quoted text On 2015/06/18 13:35:41, eernst wrote: > Maybe separate the tests into the cases that will work and the cases affected by > dartbug.com/19635, such that we can run as much as possible? I don't want to spend too much time on supporting the non-transformed program in dart2js. The dart:mirror implementation is very limited, and I don't see any payoff.
OLD	NEW