Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1181373003: [deoptimizer] Use TranslationIterator for OptimizedFrame again. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Use TranslationIterator for OptimizedFrame again. Using TranslatedState and friends is too expensive compared to the low level TranslationIterator, because some code (i.e. in Speedometer) depends on the OptimizedFrame summary/function listing to be very fast. BUG=chromium:499338 LOG=n R=jarin@chromium.org Committed: https://crrev.com/2c44f4f9deb4015555b7825c81861b06c33f346d Cr-Commit-Position: refs/heads/master@{#29037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -53 lines) Patch
M src/frames.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/frames.cc View 2 chunks +126 lines, -53 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-16 05:31:25 UTC) #1
Benedikt Meurer
Hey Jaro, This is the "performance fix" for speedometer. Basically reverts the previoius change to ...
5 years, 6 months ago (2015-06-16 05:33:07 UTC) #2
Jarin
lgtm. However, it would be nice to know whether it was GetFunctions or Summarize that ...
5 years, 6 months ago (2015-06-16 05:36:03 UTC) #3
Benedikt Meurer
> However, it would be nice to know whether it was GetFunctions or Summarize that ...
5 years, 6 months ago (2015-06-16 05:39:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181373003/1
5 years, 6 months ago (2015-06-16 05:39:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 06:04:47 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 06:05:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c44f4f9deb4015555b7825c81861b06c33f346d
Cr-Commit-Position: refs/heads/master@{#29037}

Powered by Google App Engine
This is Rietveld 408576698